feat: adding support for arbitrary field #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2717 +/- ##
==========================================
- Coverage 60.44% 60.43% -0.02%
==========================================
Files 563 563
Lines 75159 75159
==========================================
- Hits 45431 45419 -12
- Misses 26341 26349 +8
- Partials 3387 3391 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hthieu1110
changed the title
…RITORI/gno into feat/support-arbitrary-fields
hthieu1110
changed the title
hthieu1110
requested review from
jaekwon and
zivkovicmilos
and removed request for
a team
zivkovicmilos
requested changes
Aug 22, 2024
|
@hthieu1110 |
Signed-off-by: Norman Meier <norman@samourai.coop>
zivkovicmilos
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PR and Manfred's idea, this PR aims at adding possibility to add arbitrary field to profile.
I keep the same fields list defined in the struct, they would be served as "standard/base" fields and all other arbitrary fields are considered as "extra".
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description